Make pointer events affect focus #822
Conversation
PoignardAzur
changed the title
| if !root | ||
| .widget_arena | ||
| .states | ||
| .get_id_path(target_widget_id) |
There was a problem hiding this comment.
It's not clear to be in what context a possibly focusable widget could be nested inside another possibly focusable widget (that is, why this isn't just target_widget_id != focused_widget)
There was a problem hiding this comment.
I don't disagree, but I don't want to make it a hard rule either.
masonry/src/render_root.rs
Outdated
| @@ -616,7 +621,7 @@ impl RenderRoot { | |||
| } | |||
|
|
|||
| pub(crate) fn widget_from_focus_chain(&mut self, forward: bool) -> Option<WidgetId> { | |||
| let focused_widget = self.global_state.focused_widget; | |||
| let focused_widget = self.global_state.ghost_focus; | |||
There was a problem hiding this comment.
I think this should be:
| let focused_widget = self.global_state.ghost_focus; | |
| let focused_widget = self.global_state.focused_widget.or(self.global_state.ghost_focus); |
That is, if there is an actual currently focused widget, we should start from that for tab-focusing and the like.
There was a problem hiding this comment.
Mh, fair enough. I would let me remove a lot of code that tries to keep ghost focus and regular focus synchronized.
I ain't afraid of no ghost.
| @@ -74,6 +74,7 @@ pub(crate) struct RenderRootState { | |||
| pub(crate) focused_widget: Option<WidgetId>, | |||
| pub(crate) focused_path: Vec<WidgetId>, | |||
| pub(crate) next_focused_widget: Option<WidgetId>, | |||
| pub(crate) most_recently_clicked_widget: Option<WidgetId>, | |||
There was a problem hiding this comment.
It might be worth having just a sprinkling of documentation/explanation here (the same could be said about most of these fields, but this one is a bit non-obvious)
Clear the focus when user clicks outside of the focused widget
Add
most_recently_clicked_widgetvalue, so that clicking influences which widget will be focused by future Tab events.